Skip to content

fix(indicate typos): Replace tabs with _ when indicate typos is replace or both (@Leonabcd123) #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 2 commits into from
Dec 10, 2025
Merged

fix(indicate typos): Replace tabs with _ when indicate typos is replace or both (@Leonabcd123) #7191

Miodec merged 2 commits into from
Dec 10, 2025
+1 −1

Conversation

@Leonabcd123
Copy link
Contributor

@Leonabcd123 Leonabcd123 commented Dec 5, 2025 •
edited
Loading

Description

When indicate typos is set to replace or to both, make sure to have tabs replaced with _.

Current behavior is that the literal tab character replaces the char, making it disappear.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Dec 5, 2025
@Leonabcd123
Copy link
Contributor Author

Leonabcd123 commented Dec 5, 2025 •
edited
Loading

Also, I'm pretty sure that checking whether inputChars[i] === " " is useless, as inputChars will never contain a space (inputChars is just input split into characters, input is TestInput.input.current, and TestInput.input.current will be empty after a space).

There's this one time where input is inputOverride, and that should be just TestInput.input.current + options.data (hopefully options.data doesn't contain spaces?).

Gone is my confidence, we can't do this.

@Leonabcd123 Leonabcd123 force-pushed the fix-tab-in-indicate-typos-replace branch from 9485d2b to 0618944 Compare December 10, 2025 19:41
@Miodec Miodec merged commit 3482242 into monkeytypegame:master Dec 10, 2025
13 checks passed
@Leonabcd123 Leonabcd123 deleted the fix-tab-in-indicate-typos-replace branch December 10, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

frontend User interface or web stuff

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Leonabcd123 @Miodec @monkeytypegeorge